Vocabulary dictionary

Kanji dictionary

Grammar dictionary

Sentence lookup

test
 

Forums - Holiday system - feedback and bugs

Top > renshuu.org > Feature Requests/Improvements > Experimental features

Page: 4 of 4



avatar
antimonysarah
Level: 936
マイコー (0726, 20:28)

This user has already contacted me privately, in case anyone had this issue - I believe I found the problem, and should be fixed for the future. However, if your streak was broken due to this, please DM me so I can get it fixed

Thanks so much! Sorry for pestering you multiple ways, I just wasn’t sure if it mattered if it got fixed before I started up with reviews again tomorrow.

0
21 days ago
avatar
めいこち
Level: 320

Hello,

I first used the roll back feature on Wednesday, before my "day change", because I couldn't study on Monday and Tuesday, and it didn't changed my amount of study for that day, yesterday nor today, and my heatmap still has two blanks squares. Did I missed something on how this feature is supposed to work ?
I writing a message here to not bother マイコー by DM and if it's helpful to other people later (I did read the other messages here to see if anyone already asked that question), hope it was appropriate.
Thank you for all the work you did with renshuu, it's a wonderful app/website !

1
9 days ago
avatar
Elessar
Level: 288

I'm not sure if this is a bug, or an inevitability of the system, but I found some (possibly) undesirable behaviour.

I had some holidays days marked last week, but today I changed them for this week. All the schedules that I had caught up on before changing the holidays now show 0 reviews for those former holidays this week. (When I do reviews, the terms I missed are properly marked for the next day, so it's no longer zero, but the other terms don't shift.)

5d48e2599ccd2029a5f8af9b.png

The days circled in red used to be marked as holidays.

What I'm guessing is happening in the system is something like this:

  • Either each term is scheduled on the next available day corresponding to the SRS, skipping over marked holidays.
  • When the holidays are added, the terms are all shifted forward the appropriate number of days.
  • However, when holidays are removed, instead of shifting all the terms backward for days no longer marked holidays, they are simply left in place.

Can you take a look at this to see if it's a system problem, or just my account?

0
9 days ago
avatar
マイコー
Level: 343

Elessar:

This is expected behavior. Your guess is close, but a bit off. "Just moving" them to the next available date would actually cause a lot of problems: people that put sat/sun (for example) on holiday would get a triple dose of reviews on Monday, yikes!

Instead, when a holiday is set, anything that is schedule simply ceases to even see that day. So if you have sat/sun as a holiday, then from renshuu's perspective, a week now has 5 days in it. If a term is scheduled for 7 days in the future (and it is currently friday), it will count through m through friday, then back to mon > tues.

So while renshuu does not hold onto the "if holidays did not exist, it *would* have been on this day" data, even if it did, I think it would be somewhat problematic to try and shift things backwards like that (for a few reasons that I unfortunately do not have the time to detail here).

======

めいこち - the roll back does not "fix" or adjust anything in the heatmap. If you didn't study a day, you didn't study a day (and it will remain white). Rather, what it does is shift the "this term should be reviewed on 2026/xx/xx" dates on the terms the number of days you choose. That way, if you missed August 1st, 2nd, and returned on the 3rd, you'd have a stack of reviews for all three days waiting for you. If you roll it back 2 days, then August 1st > 3rd, 2nd > 4th, and 3rd > 5th. As you're on the 3rd, you now only have one day's worth of reviews to do instead of three.

It's one of those systems that I feel is very simple, but quite hard for me to skillfully explain (sorry for that!) I'm still trying to figure out the best way to explain it on that page, as you are not the first to ask about it, and so the current explanation is clearly not sufficient. I'll get it eventually!

0
7 days ago
avatar
Elessar
Level: 288
マイコー (0810, 14:45)

So while renshuu does not hold onto the "if holidays did not exist, it *would* have been on this day" data, even if it did, I think it would be somewhat problematic to try and shift things backwards like that (for a few reasons that I unfortunately do not have the time to detail here).

Yes, that would be an unnecessary complication to hold onto that data. What I was thinking of was more straightforward than that: when removing a holiday, simply shift everything one day back. But if this is too complicated, that's fine. Having the feature is already such a great addition, and I can live with this behaviour.

Thanks again for your hard work!

0
6 days ago
avatar
めいこち
Level: 320

Got it, thank you for the answer and all your work on the app !

Have a nice summer

0
6 days ago
Getting the posts


Page: 4 of 4



Top > renshuu.org > Feature Requests/Improvements > Experimental features


Loading the list
Lv.

Sorry, there was an error on renshuu! If it's OK, please describe what you were doing. This will help us fix the issue.

Characters to show:





Use your mouse or finger to write characters in the box.
■ Katakana ■ Hiragana