Vocabulary dictionary

Kanji dictionary

Grammar dictionary

Sentence lookup

test
 

Forums - Discussion: in forum dictionary lookups

Top > renshuu.org > Feature Requests/Improvements

Page: 2 of 3



avatar
マイコー
Level: 319

I'll try and check out safari later on, thanks.

2
16 days ago
avatar

I played around with the plugin a bit, and ctrl-z misbehaves a lot. Sometimes it jumps the cursor to the start (without undoing anything), sometimes it undoes the whole sentence, sometimes just one character, sometimes in chunks. Now I understand why sometimes when I try to ctrl-z a minor mistake it completely erases my whole post kao_don.png

It's fine though, I'll just be careful with ctrl-z. Don't worry about that issue.

I figured out how things work (what I showed in the video). I guess I just expected spacebar to "exit" out of the formatted tags, like the arrow keys.

I'm not a huge fan of how the system works in general. It could be related to ctrl-z's weird behaviour. Anyway, I'm just thinking out loud a bit, this doesn't matter that much, and I can easily work around it.

d5151edd2fc5180acff789d5.png

I'm not a web developer, so this might just be a case of industry standard practices being a bit foreign to me.


I'll let you know if I encounter any issues more directly related to the lookup itself. Pretty sure the backspace issue was also ctrl-z related, so I won't bother with that one.


Edit: Yeah, the ctrl-z weirdness is 100% related to the cursor position and the tags.


Update 1: Had some problems with linking in this example. Wasn't working up top (no menu pop-up).

2eafc6625edc5c67e41dc596.png


Update 2: Another issue when trying to link sentences using the old system. I get that it's not very elegant, but it does work :D

The new lookup dialogue keeps popping up. I understand why it does it, I'm just pointing it out. Shouldn't be an issue after you add sentences to the lookup.

ea7d79cff2fad9ceef9c0863.png


Update 3: Doesn't open the dictionary (error)

e9e5b12943b267f64ac3af9a.png

The error:

f68d898a2b63c5a9cdbd751d.png


Update 4: If you click a little too fast you get this.

6d24e17c5232557def395507.png

Very unlikely to be an issue, but I figured I'd let you know.

0
16 days ago
avatar
マイコー
Level: 319

1. Grammar fix going up soon.

2. Will look into the # issue with sentences. However, that wouldn't work in the old system, either: it would require three ###, as a single # was for vocabulary.

3. I am in contact (well, I am contacting them) the maintainers of the package, and I'd like to provide a specific set of steps to replicate any of the ctrl-z issues. Please use this page as a test imperavi.com/redactor/examples/images/upload-image/

Just clear out the contents, then do whatever steps need to be done to replicate it.

4. The Safari issue is WEIRD. I can replicate it on macOS, but only sometimes. The cursor appears at the right time most of the time, but if something throws it off at the beginning, it stays off the rest of the time.

2
15 days ago
avatar
マイコー
Level: 319

Also - I think I could knock some of the issues if I disallow spaces in the search. I know that, earlier on, someone looked up second world war, but I'm not sure that (multiple english words) is going to be common enough to justify that jank that comes with allowing spaces.

1
15 days ago
avatar

That was me :D

That would fix some of the issues. What about something like "second_world_war" and then you just replace "_" / " " for the lookup if you need to?

0
15 days ago
avatar
マイコー
Level: 319

I'll have to think on it - for now, I'm going to have it cut the trigger if a space is detected.

Shockingly (and I dug through the source code, without much luck), if you jump down to a newline, it considers that newline a space, so there is not a way to say "allow spaces on a line, but stop it if they jump to a newline"

0
15 days ago
avatar
マイコー
Level: 319

Ok, with the ctrl-z business, it seems to be timed to speed between each input action. There is this somewhat weird syncDelay option that is defaulted to 300ms, but I've set it down to 50ms. It at least looks like ctrl-z is working better.

0
15 days ago
avatar

Feels better... I think.

Here's one more - if I type some text, then link (いち) ← hit space once and then ctrl-z, the cursor jumps back to the start (left of "Feels"), on a second ctrl-z, it goes back to the link and starts working normally.

Doesn't break anything, but is really weird :)


PS: I'll do some more testing in the morning, it's pretty late over here.

0
15 days ago
avatar

Testing the Redactor on Imperavi.

works as expected = each single action gets undone in sequence

(The following makes sense to me given the syncDelay of 300ms)

  1. Single character + ctrl-z - works as expected.
  2. String "asdfgh" (typed slowly and waited a second) + ctrl-z - works as expected
  3. String "asdfgh" (typed fast, without waiting) + ctrl-z - whole thing gets undone
  4. String "asdfgh" (typed fast and waited a second) + ctrl-z - whole thing gets undone
  5. Two words (typed fast, with a pause) - ctrl-z goes word by word. "Two words" → "Two" → ""
  6. "Typing this really fast" (~120-150WPM) → "" (one ctrl-z)

The cursor jumping back seems to be a visual glitch (seems harmless). Easier to reproduce on Renshuu, but I'm still not sure exactly what
causes it. It sticks to index 0 (beginning), while ctrl-z seems to function as expected.

Happens 100% of the time after a dictionary link + a space + whatever (more spaces, text).


One other thing (might be intentional): On the Redactor, ctrl-z can go much further back when you've deleted everything.
This isn't the case on Renshuu. If I fully delete everything and start typing again, ctrl-z doesn't really go back very far (past "").


PS: The new syncDelay does feel much better :)

300ms is wild... who types that slowly XD

Edit: I couldn't reproduce the problem I had in "Update 1"


Testing : (すみれ) すぎる (だいにじせかいたいせん) (だいいちじせかいたいせん) ← (this was "first_world_war", so that already works). Ah... you've already made it cut the trigger on space. Did you have it handle underscores, or does that just work? (だいいちじせかいたいせん) ← (this was "first-world-war", so that also works)

0
14 days ago
avatar
ロウ (Row)
Level: 839

There's a really confusing issue where if a text box has an emoji at the end or an emoji with only a little text after it it won't let you edit the text box after posting the message

Edit: as you can see above, I accidentally added a weird line thing while editing but it refuses to let me delete it

0
14 days ago
avatar
ロウ (Row)
Level: 839

But it seems the text boxes are gone now, so maybe it doesn't matter?

0
14 days ago
avatar
ロウ (Row)
Level: 839


Ok so I think the thing セージ was talking about is that if you click quote, it won't let you delete it very easily, you have to delete it very easily, as you can see above I deleted all the text with the delete button but it won't let me delete the text box or the space above it

1
14 days ago
avatar

Ok so I think the thing セージ was talking about is that if you click quote, it won't let you delete it very easily, you have to delete it very easily, as you can see above I deleted all the text with the delete button but it won't let me delete the text box or the space above it

You're right, quoting does seem to have a lot of issues. A ton of nested elements that you can't easily delete. You can delete the text, but the actual container stays behind. I can delete them on PC (without DevTools), but even here it's pretty clunky.

cf6346981d78943facaf247c.png

I don't really get the massive 24px top margin, looks better without it, imo.

eb12b198296b4a5156e598a9.png
2
14 days ago
avatar

Test post demonstrating invisible text.

(look for an email with the video)

1
14 days ago
avatar
マイコー
Level: 319

Ok, so images at the end of the post SHOULD be better. I reached out to the company that maintains the library, but in the meantime, I got out my kludge gloves and got to work.

With quotes, maybe this is a time to revisit how to do those? The quote code has been in there since FOREVER, and hasn't been touched in ..probably 10 years.

I like discord's style of quoting, where it just adds a line or two of text, and tapping on it will jump you to that message. I've seen quotes of quotes in here on renshuu, and it just causes the visual noise in the forum to explode.

If you all have any other styles of reply/quote that you'd like to see, please let me know!

0
14 days ago
avatar
The main need for quoting is the ability to edit it down so you don’t have to quote multiple paragraphs to reply to one sentence.
1
14 days ago
avatar
マイコー
Level: 319

Based on what I've seen over the years, most people don't edit: they just leave the entire block in there :(

1
14 days ago
avatar

This might be too much work/complexity, but you do have all of these separate containers you could potentially target for a more limited quote?

0abe659aae20b9d9a4ef6408.png

PS: I still need to hit down-arrow to get below the image btw ↑ (might be fixed on mobile, idk)

0
14 days ago
avatar
マイコー
Level: 319

I'm pretty sure down-arrow didn't work before, though? There was nothing to down arrow to.

0
14 days ago
avatar

1. We're talking about when an image is at the "end" of the post (flush with the bottom) right? I'm also not sure what I'm down-arrowing to, but I am :D

I can upload an image to a completely empty post and just hit down-arrow to get to a line below it. This is on PC (Windows), Chrome.


2 (fixed). I can't link YouTube (haven't tried anything else) videos. When I post/save changes they just disappear.

There's just the empty .embed-content div that's left behind.


3. I just noticed the updated quotes. Maybe add a bit of bottom margin? Just so they aren't completely glued together.

654d5e25954ec38fc7898381.png

(Example value)

9edd573a9270bad91d0f767c.png


0
14 days ago
Getting the posts


Page: 2 of 3



Top > renshuu.org > Feature Requests/Improvements


Loading the list
Lv.

Sorry, there was an error on renshuu! If it's OK, please describe what you were doing. This will help us fix the issue.

Characters to show:





Use your mouse or finger to write characters in the box.
■ Katakana ■ Hiragana