Vocabulary dictionary

Kanji dictionary

Grammar dictionary

Sentence lookup

test
 

Forums - Word note dialogue doesn’t close

Top > renshuu.org > Bugs / Problems



avatar

The word note dialogue doesn’t close unless the x in the corner is clicked. Pressing the submit button more than once does not close it, but creates multiple notes.

1
3 days ago
avatar

It's the same here kao_dejected.png ; even if you keep on clicking on the word note message(the bold text), the boundary of the note (the white gradient) increases rather than it closing.

0
3 days ago
avatar

Yup, I guess something broke. When you click on "add usage note" it just duplicates the ttip div. They just start stacking :D

ad19019033cb9a7445c34388.png

The "Save note" button doesn't close the dialogue, and "Cancel" doesn't either. I assume the problem is somewhere in the functions tied to those buttons.

Could be the helper function that's supposed to "close" the dialogue. That would makes the most sense to me. Pretty sure the x uses a different function, so it works fine. (Not a different function, just passes arguments differently)


Edit: I guess the class name got changed to "tipp" at some point. That's not the problem, just something I noticed just now.

It may or may not have something to do with this line "tip2_hide(!1, force && closingSticky)" in tt_Hide(). "force && closingSticky" seems to always evaluate to FALSE. Not 100% sure though.


Also noticed that the "Cancel" button "half" closes on some terms, no idea why:

1494afe108d58b6e5383fa34.png
1
3 days ago
avatar
マイコー
Level: 316

Should be fixed. If it still persists, please give me the set of steps that lead to it.

The popup/modal code on renshuu is based on a library that is literally 20 years old. I have been slowly migrating the modals over to the new system, toggling on the new system for a few more each day/week.

2
2 days ago
avatar

Looks fixed to me :)

The "Add usage note" link still makes a bunch of copies that stack on top of each other, but that's not that important. You kinda have to go out of your way to trigger that bug. Might wanna fix it at some point though.

1
2 days ago
avatar
マイコー
Level: 316

No time like the present! Will get it done today.

2
2 days ago
avatar

Update: When I try to edit a note, the "Save note" button doesn't close the dialogue (it does update the note). "Cancel" either doesn't work at all, or doesn't close everything properly.

142e9695346053b193e1f45c.png
1
1 day ago
Getting the posts




Top > renshuu.org > Bugs / Problems


Loading the list
Lv.

Sorry, there was an error on renshuu! If it's OK, please describe what you were doing. This will help us fix the issue.

Characters to show:





Use your mouse or finger to write characters in the box.
■ Katakana ■ Hiragana